automate initialize #138
Merged
automate initialize #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Aug 21, 2021
|
This is going to be merged? |
lhotari
requested changes
Jan 5, 2022
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
|
@valeriano-manassero Thank you for the contribution. Would it be also possible to update README.md in this PR and remove the instructions of using |
done |
lhotari
approved these changes
Jan 5, 2022
pgier
added a commit
to pgier/pulsar
that referenced
this pull request
Jul 13, 2022
The helm option `--set initialize=true` is no longer needed. See: apache/pulsar-helm-chart#138 Signed-off-by: Paul Gier <paul.gier@datastax.com>
pgier
added a commit
to pgier/pulsar
that referenced
this pull request
Jul 13, 2022
The helm option `--set initialize=true` is no longer needed. See: apache/pulsar-helm-chart#138 Signed-off-by: Paul Gier <paul.gier@datastax.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114
Motivation
Having
initializevalue that must be manually set is prone to human error, there is a risk of running init again forcing the need of a rollback.Modifications
Using Helm capability to understand if it's an install or upgrade we can avoid to launch init when not needed.
Verifying this change