Remove double quotes from the environment variables #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* Some of the environment variables still use double quotes. They result in the following ```bash Could not find or load main class " ```
merlimat
approved these changes
Jun 23, 2020
|
@sijie I've noticed /pulsar/conf/pulsar_env.sh is returning errors without the quote(broker logs): I'm not sure if it's actually creating errors somewhere else, but is it expected? |
|
@jujugrrr I think the helm chart still tries to substitute the environment variables for some init containers in the environment file. This results in the error messages but it doesn't impact the running containers. Let me submit a fix. |
|
Thanks a lot! |
pgier
pushed a commit
to pgier/pulsar-helm-chart
that referenced
this pull request
Apr 22, 2022
rdhabalia
pushed a commit
to rdhabalia/pulsar-helm-chart
that referenced
this pull request
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the environment variables still use double quotes. They result in the following
Could not find or load main class "