-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [doc] Add compatibility reminders for retry queues #651
Conversation
@gaoran10 |
ping @gaoran10 to review, tia! |
1 similar comment
ping @gaoran10 to review, tia! |
If manually specifying the name of retry letter topic or dead letter topic can also achieve the goal we can mention it along the changes as well. It may also be worthy noting that using |
I would suggest to add the consequence in brief if continuing using |
Done |
docs/concepts-messaging.md
Outdated
Note: In versions `2.6.x` and `2.7.x`, the default retry letter topic uses this format is `<subscriptionname>-RETRY`. | ||
If you are upgrading from version `2.6.x~2.7.x` to version `2.8.x` or greater, then you need to manually delete | ||
the historical retry letter topics and retry letter partitioned topics. Otherwise, Pulsar will continue to use the | ||
original topics, which were formatted with `<subscriptionname>-RETRY`. Rule `<subscriptionname>-RETRY` should be avoided | ||
to use, because if multiple topics under the same namespace have the same subscription, the retry message topic names | ||
for multiple topics will be the same, resulting in mutual consumption. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: In versions `2.6.x` and `2.7.x`, the default retry letter topic uses this format is `<subscriptionname>-RETRY`. | |
If you are upgrading from version `2.6.x~2.7.x` to version `2.8.x` or greater, then you need to manually delete | |
the historical retry letter topics and retry letter partitioned topics. Otherwise, Pulsar will continue to use the | |
original topics, which were formatted with `<subscriptionname>-RETRY`. Rule `<subscriptionname>-RETRY` should be avoided | |
to use, because if multiple topics under the same namespace have the same subscription, the retry message topic names | |
for multiple topics will be the same, resulting in mutual consumption. | |
:::note | |
- For Pulsar 2.6.x and 2.7.x, the default retry letter topic uses the format of `<subscriptionname>-RETRY`. If you upgrade from 2.6.x~2.7.x to 2.8.x or later, you need to delete historical retry letter topics and retry letter partitioned topics. Otherwise, Pulsar continues to use original topics, which are formatted with `<subscriptionname>-RETRY`. | |
- It is not recommended to use `<subscriptionname>-RETRY` because if multiple topics under the same namespace have the same subscription, then retry message topic names for multiple topics might be the same, which will result in mutual consumptions. | |
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR fixes apache/pulsar#20612
The default naming rule of Retry topic is
{tenant}/{namespaces}/{topic}-{sub}-RETRY
, see: https://pulsar.apache.org/docs/3.0.x/concepts-messaging/#retry-letter-topicThe rule before version
2.8
was{tenant}/{namespaces}/{sub}-RETRY
, and if there is a ZK node/admin/partitioned-topics/{namespace}-RETRY
, Pulsar will still use the rule{tenant}/{namespaces}/{sub}-RETRY
even if the version of Pulsar is larger than2.8
. This part of the explanation is not reflected in the documentation.Related PR
doc
doc-required
doc-not-needed
doc-complete