Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acknowledgement for batch message local index #6253

Closed
codelipenghui opened this issue Feb 7, 2020 · 1 comment
Closed

Acknowledgement for batch message local index #6253

codelipenghui opened this issue Feb 7, 2020 · 1 comment
Assignees
@codelipenghui
Labels
type/feature The PR added a new feature or issue requested a new feature
Milestone
2.6.0

Comments

@codelipenghui
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, the managed cursor maintains the acked messages by mark delete position and individual delete messages. All of the mark delete position and individual delete messages are faced to batch messages(ledgerId,entryId). For users, the single message is the publishing and consuming unit. Since the managed cursor can’t maintain the local index of a batch message, the broker will dispatch acked messages(not batch) to consumers like the issue #5969.

So, it's better to support for batch message local index acknowledgment. This issue tracks the task for this feature.
@codelipenghui codelipenghui added the type/feature The PR added a new feature or issue requested a new feature label Feb 7, 2020
@codelipenghui codelipenghui self-assigned this Feb 7, 2020
@codelipenghui codelipenghui mentioned this issue Feb 7, 2020
Merged
@codelipenghui codelipenghui added this to the 2.6.0 milestone Feb 7, 2020
@sijie sijie mentioned this issue Feb 7, 2020
Closed
sijie pushed a commit that referenced this issue Jun 2, 2020
@codelipenghui
[PIP-54] Support acknowledgment at batch index level (#6052)
aa0fbb0 
Master issue: #6253
Fixes #5969

### Motivation

Add support for ack batch message local index. Can be disabled at broker side by set batchIndexAcknowledgeEnable=false at broker.conf

PIP-54 documentation will be created soon.

### Modifications

1. Managed cursor support track and persistent local index of batch message.
2. Client support send batch index ack to broker.
3. The batch messages with index ack information dispatched to the client.
4. Client skip the acked index.

### Verifying this change

New unit tests added
@codelipenghui
Copy link
Contributor Author

close via #6052

Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this issue Jun 12, 2020
@codelipenghui @Huanli-Meng
[PIP-54] Support acknowledgment at batch index level (apache#6052)
3642c0b 
Master issue: apache#6253
Fixes apache#5969

### Motivation

Add support for ack batch message local index. Can be disabled at broker side by set batchIndexAcknowledgeEnable=false at broker.conf

PIP-54 documentation will be created soon.

### Modifications

1. Managed cursor support track and persistent local index of batch message.
2. Client support send batch index ack to broker.
3. The batch messages with index ack information dispatched to the client.
4. Client skip the acked index.

### Verifying this change

New unit tests added
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this issue Aug 24, 2020
@codelipenghui @huangdx0726
[PIP-54] Support acknowledgment at batch index level (apache#6052)
e9f12a5 
Master issue: apache#6253
Fixes apache#5969

### Motivation

Add support for ack batch message local index. Can be disabled at broker side by set batchIndexAcknowledgeEnable=false at broker.conf

PIP-54 documentation will be created soon.

### Modifications

1. Managed cursor support track and persistent local index of batch message.
2. Client support send batch index ack to broker.
3. The batch messages with index ack information dispatched to the client.
4. Client skip the acked index.

### Verifying this change

New unit tests added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codelipenghui codelipenghui

Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
2 participants
@jiazhai @codelipenghui