[Transaction] Fix end transaction retry problem. #10131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Apr 6, 2021
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
Apr 9, 2021
## Motivation When transaction in aborting or committing status, we retry endTransaction and update status in ```TransactionMetadataStore``` will throw ```InvalidTxnStatusException```, it will not retry. so we should judge the Transaction status try to retry. ## implement 1. When Transaction status in ```OPEN```status, we can updateStatus by ```TransactionMetadataStore```. 2. When Transaction status in ```Committing``` or ```Aborting``` status, we should judge the ```TxnAction```, if txnAction corresponds to the ```TxnStatus``` only ```endTxnInTransactionBuffer```, if not we don't do any operation. 3. When Transaction status in another status, don't need to handle. 4. When ```TransactionNotFoundException``` or ```CoordinatorNotFoundException``` can stop retry op. ### Verifying this change Add the tests for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When transaction in aborting or committing status, we retry endTransaction and update status in
TransactionMetadataStorewill throwInvalidTxnStatusException, it will not retry. so we should judge the Transaction status try to retry.implement
OPENstatus, we can updateStatus byTransactionMetadataStore.CommittingorAbortingstatus, we should judge theTxnAction, if txnAction corresponds to theTxnStatusonlyendTxnInTransactionBuffer, if not we don't do any operation.TransactionNotFoundExceptionorCoordinatorNotFoundExceptioncan stop retry op.Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)