Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add /opt/homebrew/ as a possible path for OpenSSL on Mac #10141

Merged
merged 1 commit into from
Apr 8, 2021
Merged

[C++] Add /opt/homebrew/ as a possible path for OpenSSL on Mac #10141

merged 1 commit into from
Apr 8, 2021

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Apr 5, 2021

Motivation

On Mac, Homebrew has changed the default install location from /usr/local to /opt/homebrew. When looking for OpenSSL headers and libs, we should include the new path as well.

Additionally, the OpenSSL include directories were specified twice, which is not needed.

@merlimat merlimat added this to the 2.8.0 milestone Apr 5, 2021
@merlimat merlimat self-assigned this Apr 5, 2021
eolivelli
eolivelli approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

aahmed-se
aahmed-se reviewed Apr 5, 2021
View reviewed changes
Copy link
Contributor

@aahmed-se aahmed-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect
brew now uses /usr/local/opt/openssl@1.1/

@merlimat
Copy link
Contributor Author

merlimat commented Apr 5, 2021

It depends when home-brew was installed. New installs are /opt/homebrew

$ ll /opt/homebrew/opt/openssl
lrwxr-xr-x  1 mmerli  admin  28 Apr  4 12:01 /opt/homebrew/opt/openssl -> ../Cellar/openssl@1.1/1.1.1k

$ ll /usr/local/opt/openssl@1.1/
ls: /usr/local/opt/openssl@1.1/: No such file or directory

@merlimat merlimat merged commit dd19702 into apache:master Apr 8, 2021
wangjialing218 pushed a commit to wangjialing218/pulsar that referenced this pull request Apr 9, 2021
@merlimat
[C++] Add /opt/homebrew/ as a possible path for OpenSSL on Mac (apach…
fb6950d 
…e#10141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aahmed-se aahmed-se aahmed-se left review comments

@eolivelli eolivelli eolivelli approved these changes

@sijie sijie Awaiting requested review from sijie

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@jiazhai jiazhai Awaiting requested review from jiazhai

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@merlimat merlimat

Labels
area/build
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@merlimat @aahmed-se @eolivelli