[Transaction] Fix transactionMetadata store recover timeout problem. #10162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Apr 8, 2021
|
/pulsarbot run-failure-checks |
| @@ -40,11 +40,10 @@ | |||
| private final TripleLongPriorityQueue priorityQueue = new TripleLongPriorityQueue(); | |||
| private final long tickTimeMillis; | |||
| private final Clock clock; | |||
| private Timeout currentTimeout; | |||
| private volatile Timeout currentTimeout; | |||
There was a problem hiding this comment.
Do we need volatile here? Seem it is protected by the synchronized.
added 2 commits
April 19, 2021 09:28
…r_problem # Conflicts: # pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
sijie
approved these changes
Apr 20, 2021
|
This PR introduced a flaky test #10310 . Please fix. |
lhotari
reviewed
Apr 21, 2021
| field.setAccessible(true); | ||
| ConcurrentMap<TxnID, Pair<TxnMeta, List<Position>>> txnMap = | ||
| (ConcurrentMap<TxnID, Pair<TxnMeta, List<Position>>>) field.get(transactionMetadataStore); | ||
| assertEquals(txnMap.size(), 1); |
There was a problem hiding this comment.
@congbobo184 This assertion assertEquals(txnMap.size(), 1); is flaky (#10310), could it be removed?
There was a problem hiding this comment.
+1 for removing it.
@lhotari can you please send a PR ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
currentTime+transactionTimeout, it is not right. it need to usestartTransactionTime+transactionTimeout.priorityQueueimplement
fix the logical of the transaction timeout.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)