[broker] Limit the number of producers/consumers that can connect per topic for each IP address #10188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massakam
added
type/enhancement
nkurihar
approved these changes
Apr 13, 2021
315157973
reviewed
Apr 13, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
|
We have recently encountered a similar problem. We need a maximum number of connections based on IP. |
|
@315157973 Addressed your comments. PTAL. |
massakam
force-pushed
the
max-clients
branch
2 times, most recently
from
47dedc3
to
cac8ab3
Compare
|
@315157973 Can you review this PR again? |
315157973
reviewed
Apr 20, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Outdated
Show resolved
Hide resolved
added 4 commits
April 21, 2021 13:46
|
@315157973 PTAL |
codelipenghui
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Occasionally, a client application developer makes an implementation mistake and increases the number of producers or consumers infinitely. If this happens, there is concern that all file descriptors on the broker server will be exhausted.
Brokers already have settings such as
maxProducersPerTopicandmaxConsumersPerTopic, which allow us to specify a maximum number of clients that can connect per topic. However, if one topic is used by multiple tenants, there is an issue that if one tenant accidentally increases the number of connected clients too much, other tenants will not be able to add new clients.Modifications
Enable users to limit the number of producers or consumers which can connect to each topic with the same IP address.