[Transaction] Fix transaction log recover sequenceId problem. #10224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,4 +50,5 @@ message TransactionMetadataEntry { | |||
| optional uint64 timeout_ms = 8; | |||
| optional uint64 start_time = 9; | |||
| optional uint64 last_modification_time = 10; | |||
| optional uint64 max_sequence_id = 11; | |||
There was a problem hiding this comment.
Is it better to use max_local_txn_id
added 3 commits
April 18, 2021 23:55
…_problem # Conflicts: # pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
| @@ -586,6 +588,48 @@ public void asyncReadEntries(int numberOfEntriesToRead, long maxSizeBytes, ReadE | |||
| ledger.asyncReadEntries(op); | |||
| } | |||
|
|
|||
| public CompletableFuture<Entry> readLastConfirmEntry() { | |||
There was a problem hiding this comment.
You can use getLastPosition() method of the ManagedLedger directly.
codelipenghui
requested changes
Apr 21, 2021
| @@ -586,6 +588,47 @@ public void asyncReadEntries(int numberOfEntriesToRead, long maxSizeBytes, ReadE | |||
| ledger.asyncReadEntries(op); | |||
| } | |||
|
|
|||
| public CompletableFuture<Entry> readSpecifyPositionByPosition(PositionImpl position) { | |||
There was a problem hiding this comment.
We already have a method asyncReadEntry in the ManagedLedgerImpl, it's better to use the current implementation directly.
added 4 commits
April 22, 2021 23:48
…_problem # Conflicts: # pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionLogImpl.java
eolivelli
approved these changes
Apr 23, 2021
codelipenghui
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
now recover transaction log can't get the correct sequenceID. cursor will ack the
lastConfirmEntry.implement
lastConfirmEntry.managedLedgerproperties.Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)