Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broker] Fix replicated subscriptions related LightProto issues #10247

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Apr 16, 2021

Motivation

While investigating the issue about geo replication, #10054 , I came across some issues with handling of some deserialized replicated subscriptions related messages. LightProto reuses thread local instances and therefore a copy must be made before sharing with other threads.

Modifications

  • Make a copy of ReplicatedSubscriptionsSnapshot before adding it to ReplicatedSubscriptionSnapshotCache
  • Make a copy of MarkersMessageIdData before adding it to responses map in ReplicatedSubscriptionsSnapshotBuilder

@lhotari
Copy link
Member Author

lhotari commented Apr 16, 2021

@merlimat Please review.

@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label Apr 16, 2021
@merlimat merlimat added this to the 2.8.0 milestone Apr 16, 2021
@merlimat merlimat merged commit 8128b88 into apache:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants