Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause the replicated subscriptions snapshots when there is no real traffic #10292

Conversation

merlimat
Copy link
Contributor

Motivation

Fixes #6437

This is a different approach to fix the issue, alternative to #7299.

Instead of automatically acking the marker messages when the consumers are not connected, we should instead stop taking the snapshot when there's no traffic. There's no point in continuing storing these snapshots all the time if there's no traffic.

Modifications

  1. When we detect that there has been no new messages since the last snapshot was take, skip the new snapshot.
  2. When there are no local producers, skip 1 snapshot creation. This is done in order to create a quiet period and give more time to not have any remote markers since our last snapshot was created.

@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Apr 21, 2021
@merlimat merlimat added this to the 2.8.0 milestone Apr 21, 2021
@merlimat merlimat self-assigned this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backlog messages increase if no consumer is connected to replicated subscription
2 participants