Add CI to verify C++ client could be built on Windows #10387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Apr 26, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Apr 27, 2021
* Add vcpkg dependencies * Add dependencies for compression * Add C++ client Windows build CI * Remove redundant variables * Update README * Fix compile error (cherry picked from commit d81c16a)
codelipenghui
added
cherry-picked/branch-2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I've seen many users have problems building Pulsar C++ client on Windows. Also there's no CI for Windows build now. After investigating on how to introduce 3rd party C++ libraries on Windows, I found vcpkg is a simple solution, which supports downloading and building dependencies from source that could avoid ABI incompatibilies.
Modifications
vcpkg.jsonto specify the C++ client's dependencies. Here we can just importboostinstead ofboost-[component name], however, it takes much more time on my laptop.vcpkgto build C++ client on Windows. On the other hand, some outdated descriptions are fixed.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.