-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Add support for setting time based limit on backlog quota with CLI. #10401
[CLI] Add support for setting time based limit on backlog quota with CLI. #10401
Conversation
/pulsarbot run-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this configuration also take effect at the broker level? I can't find configuration backlogQuotaDefaultLimitSecond
in broker.conf
Probably need to pull latest mainline, the broker side change should be merged via this pr: #10093 |
In this PR, broker.conf does not include this option as well. Should we add it? |
@315157973 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/pulsarbot rerun-failure-checks |
1 similar comment
/pulsarbot rerun-failure-checks |
Fixes #9680
This change added tests and can be verified as follows:
Added unit test.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation