Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Add support for setting time based limit on backlog quota with CLI. #10401

Merged
merged 4 commits into from
May 15, 2021

Conversation

MarvinCai
Copy link
Contributor

Fixes #9680

This change added tests and can be verified as follows:

Added unit test.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: yes
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@MarvinCai
Copy link
Contributor Author

/pulsarbot run-failure-checks

Copy link
Contributor

@315157973 315157973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this configuration also take effect at the broker level? I can't find configuration backlogQuotaDefaultLimitSecond in broker.conf

@MarvinCai
Copy link
Contributor Author

MarvinCai commented May 2, 2021

Does this configuration also take effect at the broker level? I can't find configuration backlogQuotaDefaultLimitSecond in broker.conf

Probably need to pull latest mainline, the broker side change should be merged via this pr: #10093

@315157973
Copy link
Contributor

Does this configuration also take effect at the broker level? I can't find configuration backlogQuotaDefaultLimitSecond in broker.conf

Probably need to pull latest mainline, the broker side change should be merged via this pr: #10093

In this PR, broker.conf does not include this option as well. Should we add it?

@sijie sijie added this to the 2.8.0 milestone May 4, 2021
@MarvinCai MarvinCai requested a review from 315157973 May 7, 2021 11:02
@MarvinCai
Copy link
Contributor Author

@315157973
Yes it's a broker config, added to broker.conf and standalone.conf
PTAL

Copy link
Contributor

@315157973 315157973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarvinCai
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

1 similar comment
@MarvinCai
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui merged commit 96325b9 into apache:master May 15, 2021
@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin area/cli doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backlog quota: allow time-based quota
5 participants