-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka connect sink adaptor to support non-primitive schemas #10410
Conversation
only the last commit is relevant here; the rest are from parent PR |
dca5452
to
a7db773
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
I left one comment (possibly one bug, we should add a test case for KV if it is missing)
and one code style suggestion (not a big deal)
...aptor/src/main/java/org/apache/pulsar/io/kafka/connect/schema/PulsarSchemaToKafkaSchema.java
Outdated
Show resolved
Hide resolved
...aptor/src/main/java/org/apache/pulsar/io/kafka/connect/schema/PulsarSchemaToKafkaSchema.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sijie the patch is ready for review
@codelipenghui Can you take a look please? |
eae35f2
to
7593950
Compare
(cherry picked from commit cf50da3)
Motivation
Add support of non-primitive schemas (avro, json) to kafka adaptor sink.
Modifications
Added schema support.
Verifying this change
This change added tests and can be verified as follows:
Added unit tests
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation