Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transaction] Transaction admin api get transaction coordinator status. #10639

Conversation

congbobo184
Copy link
Contributor

Motivation

Transaction add admin api getCoordinatorStatus

implement

    /** The transaction coordinatorId. */
    public long coordinatorId;

    /** The state of this transaction metadataStore. */
    public String state;

    /** The sequenceId of transaction metadataStore. */
    public long sequenceId;

    /** The low water mark of transaction metadataStore. */
    public long lowWaterMark;

This is transaction buffer metrics.

Verifying this change

Add the tests for it

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (yes)
Anything that affects deployment: (no)

…_admin_api

# Conflicts:
#	pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

});
}
} else {
asyncResponse.resume(new RestException(503, "Broker don't support transaction!"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about "This Broker is not configured with transactionCoordinatorEnabled=true." ?

@codelipenghui codelipenghui added area/transaction component/txn/coordinator doc-required Your PR changes impact docs and you will update later. labels May 20, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone May 20, 2021
@codelipenghui codelipenghui merged commit b7a5489 into apache:master May 20, 2021
@Anonymitaet
Copy link
Member

Confirmed w/ @congbobo184, the doc has been added in this PR.

@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-required Your PR changes impact docs and you will update later. labels May 20, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
…s. (apache#10639)

## Motivation
Transaction add admin api `getCoordinatorStatus`

## implement
```
    /** The transaction coordinatorId. */
    public long coordinatorId;

    /** The state of this transaction metadataStore. */
    public String state;

    /** The sequenceId of transaction metadataStore. */
    public long sequenceId;

    /** The low water mark of transaction metadataStore. */
    public long lowWaterMark;
```
This is transaction buffer metrics.
### Verifying this change
Add the tests for it
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…s. (apache#10639)

## Motivation
Transaction add admin api `getCoordinatorStatus`

## implement
```
    /** The transaction coordinatorId. */
    public long coordinatorId;

    /** The state of this transaction metadataStore. */
    public String state;

    /** The sequenceId of transaction metadataStore. */
    public long sequenceId;

    /** The low water mark of transaction metadataStore. */
    public long lowWaterMark;
```
This is transaction buffer metrics.
### Verifying this change
Add the tests for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transaction doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants