Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using AutoProduceBytesSchema as the function output schema #10716

Merged
merged 12 commits into from
May 29, 2021

Conversation

gaoran10
Copy link
Contributor

@gaoran10 gaoran10 commented May 26, 2021

Motivation

Currently, in function, we couldn't use the AutoProduceBytesSchema as the output schema.

Modifications

Support users use the AUTO_PUBLISH as the value of configuration schemaType in function. Such as --schema-type AUTO_PUBLISH

Verifying this change

Add a new integration test.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (yes)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli
Copy link
Contributor

great stuff.
I am happy than now with have msg.getReaderSchema() and we can do this kind of processing

@codelipenghui codelipenghui added this to the 2.8.0 milestone May 27, 2021
@eolivelli
Copy link
Contributor

Do we have to add some docs ? (in a follow up PR)

I did the same for Sink and for Source<byte[]> and AutoProduceBytes

Copy link
Contributor

@congbobo184 congbobo184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@315157973 315157973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui merged commit 10ed501 into apache:master May 29, 2021
wangjialing218 pushed a commit to wangjialing218/pulsar that referenced this pull request May 31, 2021
…pache#10716)

### Motivation

Currently, in function, we couldn't use the `AutoProduceBytesSchema` as the output schema.

### Modifications

Support users use the `AUTO_PUBLISH` as the value of configuration `schemaType` in function. Such as `--schema-type AUTO_PUBLISH`
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
…pache#10716)

### Motivation

Currently, in function, we couldn't use the `AutoProduceBytesSchema` as the output schema.

### Modifications

Support users use the `AUTO_PUBLISH` as the value of configuration `schemaType` in function. Such as `--schema-type AUTO_PUBLISH`
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…pache#10716)

### Motivation

Currently, in function, we couldn't use the `AutoProduceBytesSchema` as the output schema.

### Modifications

Support users use the `AUTO_PUBLISH` as the value of configuration `schemaType` in function. Such as `--schema-type AUTO_PUBLISH`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants