[Security] Exclude grpc-okhttp dependency and set okhttp3 & okio version #11025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- okhttp 2.7.4 dependency causes Pulsar to be flagged as vulnerable. this dependency is pulled in by the unnecessary grpc-okhttp dependency. - set okhttp3 and okio versions in dependency management since the okio versio changed when exclusions were added.
lhotari
requested review from
sijie,
aahmed-se,
merlimat,
codelipenghui and
eolivelli
sijie
approved these changes
Jun 24, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ion (apache#11025) ### Motivation - okhttp 2.7.4 dependency causes Pulsar to be flagged as vulnerable. this dependency is pulled in by the unnecessary grpc-okhttp dependency. ### Modifications - exclude grprc-okhttp and it's transitive dependencies - set okhttp3 and okio versions in dependency management since the okio versio changed when exclusions were added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
this dependency is pulled in by the unnecessary grpc-okhttp dependency.
Modifications
exclude grprc-okhttp and it's transitive dependencies
set okhttp3 and okio versions in dependency management since the okio versio
changed when exclusions were added.