Added infinite time retention configuration option #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
sijie
approved these changes
Jan 29, 2018
rdhabalia
reviewed
Jan 30, 2018
| @@ -300,10 +300,12 @@ void run() throws PulsarAdminException { | |||
| private java.util.List<String> params; | |||
|
|
|||
| @Parameter(names = { "--time", | |||
| "-t" }, description = "Retention time in minutes (or minutes, hours,days,weeks eg: 100m, 3h, 2d, 5w)", required = true) | |||
| "-t" }, description = "Retention time in minutes (or minutes, hours,days,weeks eg: 100m, 3h, 2d, 5w). " | |||
There was a problem hiding this comment.
should we also update it in cli-admin docs?
There was a problem hiding this comment.
Good point. I'll add it
merlimat
force-pushed
the
infinite-retention
branch
from
acd9be0
to
cecae91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, there is no direct way to configure an "infinite" retention time on data published on Pulsar topics, other than setting a very high value for both retention time and size.
We should have a better way to mean "infinite", by allowing to specify -1.
Modifications