Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #11348][pulsar-broker] Fix can not get leader broker in follower brokers #11353

Merged
merged 2 commits into from
Jan 18, 2022
Merged

[Issue #11348][pulsar-broker] Fix can not get leader broker in follower brokers #11353

merged 2 commits into from
Jan 18, 2022

Conversation

Demogorgon314
Copy link
Member

Fixes #11348

Motivation

The follower broker use pulsar-admin should be able to get leader-broker

Verifying this change

A new test was added for verifying the follower broker to get leader-broker

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

This is a bug fix, no need documentation.

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Jul 19, 2021
@Anonymitaet
Copy link
Member

Anonymitaet commented Jul 19, 2021 •
edited
Loading

@Demogorgon314 thanks for providing doc-related info!

@sijie sijie added this to the 2.9.0 milestone Jul 19, 2021
@eolivelli eolivelli modified the milestones: 2.9.0, 2.10.0 Oct 6, 2021
shoothzj
shoothzj approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@shoothzj shoothzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a rebase

@Demogorgon314 Demogorgon314 force-pushed the fix_get_leader_broker_in_follower branch from a8e11a2 to a791060 Compare January 18, 2022 03:14
@Demogorgon314
Copy link
Member Author

Look like #13066 already fixed this issue, I just add a test to verify it.

@codelipenghui codelipenghui merged commit 6a2e6fc into apache:master Jan 18, 2022
@Demogorgon314 Demogorgon314 deleted the fix_get_leader_broker_in_follower branch January 18, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoothzj shoothzj shoothzj approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@gaozhangmin gaozhangmin gaozhangmin approved these changes

@Jason918 Jason918 Jason918 approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jiazhai jiazhai Awaiting requested review from jiazhai

Assignees

@Demogorgon314 Demogorgon314

Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

[Pulsar admin] Can not get leader broker in non-leader brokers.
8 participants
@Demogorgon314 @Anonymitaet @Jason918 @gaozhangmin @codelipenghui @shoothzj @sijie @eolivelli