Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[websocket] Remove System.out.println from ConsumerHandler #11459

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

massakam
Copy link
Contributor

System.out.println is called in the code of WebSocket proxy. This seems to be for debugging and I think it should be removed.

@massakam massakam added this to the 2.9.0 milestone Jul 27, 2021
@massakam massakam self-assigned this Jul 27, 2021
@BewareMyPower BewareMyPower merged commit ee202d0 into apache:master Jul 27, 2021
@massakam massakam deleted the remove-debug-msg branch July 27, 2021 07:04
@eolivelli
Copy link
Contributor

@massakam:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

zymap pushed a commit that referenced this pull request Oct 22, 2021
`System.out.println` is called in the code of WebSocket proxy. This seems to be for debugging and I think it should be removed.

(cherry picked from commit ee202d0)
@zymap zymap added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Oct 22, 2021
@Anonymitaet Anonymitaet added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 11, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
)

`System.out.println` is called in the code of WebSocket proxy. This seems to be for debugging and I think it should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/websocket cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants