Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the test stability of transactionTest #11541

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Increase the test stability of transactionTest #11541

merged 3 commits into from
Aug 5, 2021

Conversation

liangyepianzhou
Copy link
Contributor

@liangyepianzhou liangyepianzhou commented Aug 3, 2021 •
edited
Loading

Motivation

  • Increase the test stability of transactionTest
  • Wait until TransactionCoordinator TransactionMetadataStoreState.State.Ready

Modifications

  • Modify TransactionTestBase::waitForCoordinatorToBeAvailable
  • Add waitForCoordinatorToBeAvailable() in Transaction*Test::setup()

Verifying this change

  • Because of the changes made in the test, there is no need to add additional verification

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

For this PR, we don't need to update docs.

  • This is just an optimization of the previous test

@liangyepianzhou liangyepianzhou changed the title Wait until TransactionCoordinator TransactionMetadataStoreState.State.Ready Wait until TransactionCoordinator_TransactionMetadataStoreState.State.Ready Aug 3, 2021
@liangyepianzhou liangyepianzhou changed the title Wait until TransactionCoordinator_TransactionMetadataStoreState.State.Ready Wait until TransactionCoordinator TransactionMetadataStoreState.State.Ready Aug 3, 2021
@liangyepianzhou liangyepianzhou changed the title Wait until TransactionCoordinator TransactionMetadataStoreState.State.Ready Increase the test stability of transactionTest Aug 3, 2021
@congbobo184 congbobo184 requested review from congbobo184, eolivelli and codelipenghui and removed request for congbobo184 and eolivelli August 3, 2021 10:30
@liangyepianzhou
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@liangyepianzhou
Copy link
Contributor Author

/pulsarbot run-failure-checks

@zymap zymap added this to the 2.9.0 milestone Aug 4, 2021
@codelipenghui codelipenghui merged commit bbe08fb into apache:master Aug 5, 2021
LeBW pushed a commit to LeBW/pulsar that referenced this pull request Aug 9, 2021
@liangyepianzhou @LeBW
Increase the test stability of transactionTest (apache#11541)
280ccd2
codelipenghui pushed a commit that referenced this pull request Sep 9, 2021
@liangyepianzhou @codelipenghui
Increase the test stability of transactionTest (#11541)
3d57af1 
(cherry picked from commit bbe08fb)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 9, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@liangyepianzhou @ciaocloud
Increase the test stability of transactionTest (apache#11541)
edd2d02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@gaoran10 gaoran10 Awaiting requested review from gaoran10

Assignees

@liangyepianzhou liangyepianzhou

Labels
area/transaction cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.2
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@liangyepianzhou @codelipenghui @zymap