Fix subscribeRateLimiter cannot be disabled #11614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Aug 11, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 24, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation SubscribeRateLimiter cannot be disabled now. When there are many subscriptions, it will cause some memory leaks. 1) Even if subscribeThrottlingRatePerConsumer=0, each subscription will still create SubscribeRateLimiter 2) Whether it is Broker-level, namespace-level or topic-level, after SubscribeRateLimiter is enabled, it cannot be disabled <img width="1766" alt="memory2" src="https://user-images.githubusercontent.com/9758905/128804604-6251d63d-dd8d-44cd-80c7-9b773c1b0f36.png"> <img width="893" alt="memory" src="https://user-images.githubusercontent.com/9758905/128804608-c434f5c7-e315-47d0-a118-ab6221d98099.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SubscribeRateLimiter cannot be disabled now.
When there are many subscriptions, it will cause some memory leaks.