Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check null or empty instead of catch NPE #11655

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

Technoboy-
Copy link
Contributor

Motivation

  • Check variable first instead of catch NPE.

Documentation

This is code-optimized, no need to update the doc.

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Aug 13, 2021
@Technoboy-
Copy link
Contributor Author

/pulsarbot run-failure-checks

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.9.0 milestone Aug 16, 2021
@codelipenghui codelipenghui merged commit e505018 into apache:master Aug 16, 2021
codelipenghui pushed a commit that referenced this pull request Sep 9, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 9, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@Technoboy- Technoboy- deleted the check-insteadof-exception branch August 10, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants