Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[branch-2.7] Support setting KEY_BASED batch builder for Pulsar Sinks #11710

Merged
merged 1 commit into from
Aug 26, 2021
Merged

[branch-2.7] Support setting KEY_BASED batch builder for Pulsar Sinks #11710

merged 1 commit into from
Aug 26, 2021

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Aug 19, 2021

Motivation

Modifications

  • include batchBuilder in ProducerSpec -> ProducerConfig.ProducerConfigBuilder conversion since it was missing
  • support setting batch builder with "--batch-builder KEY_BASED" argument

@lhotari
[branch-2.7] Support setting KEY_BASED batch builder for Pulsar Sinks…
95409fb 
… (backports apache#11706)

- backports apache#11706 to branch-2.7

- include batchBuilder in ProducerSpec -> ProducerConfig.ProducerConfigBuilder conversion
  since it was missing

- support setting batch builder with "--batch-builder KEY_BASED" argument
@lhotari lhotari self-assigned this Aug 19, 2021
@lhotari lhotari requested a review from eolivelli August 19, 2021 07:24
@lhotari lhotari mentioned this pull request Aug 19, 2021
Merged
@lhotari lhotari added the type/bug The PR fixed a bug or issue reported a bug label Aug 19, 2021
@Anonymitaet
Copy link
Member

Thanks for your contribution. For this PR, do we need to update docs?

(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@lhotari lhotari added the doc-not-needed Your PR changes do not impact docs label Aug 20, 2021
@lhotari
Copy link
Member Author

lhotari commented Aug 20, 2021 •
edited
Loading

Thanks for your contribution. For this PR, do we need to update docs?

@Anonymitaet No. This is a backport of the bug fix #11706 .

eolivelli
eolivelli approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit 2d00447 into apache:branch-2.7 Aug 26, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeznet freeznet freeznet approved these changes

@eolivelli eolivelli eolivelli approved these changes

@addisonj addisonj Awaiting requested review from addisonj

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

Assignees

@lhotari lhotari

Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life doc-not-needed Your PR changes do not impact docs release/2.7.4 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lhotari @Anonymitaet @freeznet @eolivelli @codelipenghui