Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the uncorrect VisableTesting annotation in pulsar-client #11784

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

shoothzj
Copy link
Member

Those method are not used only by test code.
Keep the annotation makes people confused.

Documentation

It's an internal change, so we don't need doc.

@shoothzj shoothzj force-pushed the master branch 2 times, most recently from 157f77d to a6adc04 Compare August 30, 2021 00:47
@shoothzj
Copy link
Member Author

@eolivelli @merlimat PTAL

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't verified all the points

but the patch looks good to me
+1

@shoothzj shoothzj force-pushed the master branch 2 times, most recently from 7531662 to ddb3f17 Compare September 2, 2021 02:48
@shoothzj
Copy link
Member Author

shoothzj commented Sep 2, 2021

@codelipenghui @sijie

@codelipenghui codelipenghui added this to the 2.9.0 milestone Sep 2, 2021
@codelipenghui codelipenghui merged commit 4147db8 into apache:master Sep 2, 2021
codelipenghui pushed a commit that referenced this pull request Sep 9, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 9, 2021
michaeljmarshall pushed a commit to datastax/pulsar that referenced this pull request Dec 8, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants