-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build from submodules (broker, transaction coordinator) #11795
Fix build from submodules (broker, transaction coordinator) #11795
Conversation
…lsar-transaction-coordinator)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Please revert formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hangc0276 @lhotari PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
merged to master branch, nice work @nicoloboschi |
(cherry picked from commit ea1e0f4)
Motivation
Currently running
mvn install -DskipTests
frompulsar/pulsar-broker
andpulsar/pulsar-transaction/coordinator
is failing due to (see also #11030)Modifications
Added
maven-properties-plugin
oninitalize
Maven phase, which sets two system properties used by protostuff (used by protolight plugin)proto_path
: added the root directory in order to resolve imports likepulsar-common/src/main/proto/PulsarApi.proto
proto_search_strategy
: value 2 (default value is not working, I feel it's buggy)see https://github.com/protostuff/protostuff/blob/master/protostuff-parser/src/main/java/io/protostuff/parser/DefaultProtoLoader.java for more context
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
For this PR, do we need to update docs?
Not needed