Forget to update memory usage on producer close #11906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
eolivelli,
codelipenghui,
hangc0276,
lhotari,
merlimat and
sijie
BewareMyPower
added
area/broker
type/bug
BewareMyPower
approved these changes
Sep 3, 2021
| @@ -907,6 +908,7 @@ protected WriteInEventLoopCallback newObject(Handle<WriteInEventLoopCallback> ha | |||
| log.info("[{}] [{}] Closed Producer", topic, producerName); | |||
| setState(State.Closed); | |||
| pendingMessages.forEach(msg -> { | |||
| client.getMemoryLimitController().releaseMemory(msg.uncompressedSize); | |||
There was a problem hiding this comment.
Do you know if we should also call msg.sendComplete(ex); in this block? It seems like these messages would have failed, as the producer is closed and these are pending messages. (This comment is independent of your PR. I'm just asking because I noticed it in the surrounding code while reviewing your PR.)
There was a problem hiding this comment.
You are right, we should also call msg.sendComplete(ex) too, I can fix it after this PR being merged
congbobo184
approved these changes
Sep 3, 2021
merlimat
approved these changes
Sep 6, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 9, 2021
(cherry picked from commit ad9efae)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The client doesn't upate the memory counter when producer close
Modifications
When the producer close, update the memory usage too.
Documentation
We don't need to update docs, because it's a bug fix.