[PIP-82] [pulsar-broker] Misc fixes: #11918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
kaushik-develop
force-pushed
the
fix_quota_calc_race
branch
2 times, most recently
from
56e1bf9
to
f6323a3
Compare
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
- fix a race between accummulating/reporting/retrieving local-usage RG stats - fix a bug in calling quota-calculator from the local-usage aggregator
kaushik-develop
force-pushed
the
fix_quota_calc_race
branch
from
f6323a3
to
06bd2af
Compare
|
/pulsarbot run-failure-checks |
jerrypeng
approved these changes
Sep 7, 2021
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Nov 4, 2021
- fix a race between accummulating/reporting/retrieving local-usage RG stats - fix a bug in calling quota-calculator from the local-usage aggregator Co-authored-by: Kaushik Ghosh <kaushikg@splunk.com>
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
- fix a race between accummulating/reporting/retrieving local-usage RG stats - fix a bug in calling quota-calculator from the local-usage aggregator Co-authored-by: Kaushik Ghosh <kaushikg@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes a couple of bugs found during testing of publish rate limiter for resource groups
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
mvn test -Dtest=org.apache.pulsar.broker.resourcegroup.ResourceGroupUsageAggregationTest -pl pulsar-broker
mvn test -Dtest=org.apache.pulsar.broker.resourcegroup.ResourceQuotaCalculatorImplTest -pl pulsar-broker
mvn test -Dtest=org.apache.pulsar.broker.resourcegroup.RGUsageMTAggrWaitForAllMesgsTest -pl pulsar-broker
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs? no
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)