[Transaction] Add transaction perf #11933

liangyepianzhou · 2021-09-06T09:56:53Z

Master Issue: ##11765

Motivation

When opening a transaction, what is the delay and rate of pulsar sending and consuming messages?
How does the granularity of the transaction affect the rate at which pulsar produces or consumes messages
Is the rate of abort and commit transactions different
Try to keep the functions of ordinary produce perfand consume perf as much as possible

Modifications

Add PerformanceTransaction.Class

According to the number of topics set by the user, each topic starts a thread to execute a number of transactions asynchronously.
If there is a preset transaction value, the production or consumption of this topic is terminated after the corresponding number of transactions is executed, and the production and consumption of all topics are summed up. After the consumption ends, the main thread ends.
Each consumer can have multiple subscriptions, but each subscription has only one consumer. In order to better compare the rate of production and consumption.

Verifying this change

Not yet

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

doc-required

(If you need help on updating docs, create a doc issue)
no-need-doc

(Please explain why)
doc

(If this PR contains doc changes)

gaoran10

Could we reuse the existing perf components? Such as PerformanceClient, PerformanceProducer and PerformanceConsumer.

liangyepianzhou · 2021-09-06T12:04:46Z

Could we reuse the existing perf components? Such as PerformanceClient, PerformanceProducer and PerformanceConsumer.

Their logic is different, and they did not extract the generic component. I don't think it's suitable

Anonymitaet · 2021-09-07T01:16:24Z

@liangyepianzhou Thanks for your contribution. Please do not forget to add docs accordingly to allow users to know your great code changes. And you can ping me to review the docs, thanks.

hangc0276 · 2021-09-07T01:24:58Z

Can we divide produce and consume in separate file? Users can test produce with transaction and consume with transaction individually. Otherwise, we may add a script in bin/pulsar-perf to start the transaction perf

eolivelli

Very interesting idea.

We need this kind of tools in order to be able to test transactions properly.

This is a brand new tool, can you please start a discussion on dev@pulsar.apache.org ?
this way we can discuss in the community

liangyepianzhou · 2021-10-11T10:33:06Z

/pulsarbot run-failure-checks

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceTransaction.java

eolivelli · 2021-10-12T06:32:08Z

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceTransaction.java

+        @Parameter(names = {"--txn-disEnable"}, description = "Disable transaction")
+        public boolean isDisEnableTransaction = false;
+
+        @Parameter(names = {"-abort"}, description = "Abort the transaction. (After --txn-disEnable "


why some arguments have a double "-" and some other arguments have a single "-" ?

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceTransaction.java

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/utils/PerformanceUtils.java

eolivelli · 2021-10-12T14:28:49Z

I am moving this PR to 2.10.0
we could possibly cherry pick to 2.9.1

I believe that it is not useful to add this to 2.8 branch as transactions evolved

congbobo184 · 2021-11-08T03:55:44Z

@eolivelli please review again, thanks.

liangyepianzhou · 2021-11-08T11:50:11Z

/pulsarbot run-failure-checks

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java

eolivelli

LGTM

let's go with this first version of the tool

Master Issue: #apache#11765 ### Motivation - When opening a transaction, what is the delay and rate of pulsar sending and consuming messages? - How does the granularity of the transaction affect the rate at which pulsar produces or consumes messages - Is the rate of abort and commit transactions different - Try to keep the functions of ordinary produce perfand consume perf as much as possible ### Modifications Add PerformanceTransaction.Class - According to the number of topics set by the user, each topic starts a thread to execute a number of transactions asynchronously. - If there is a preset transaction value, the production or consumption of this topic is terminated after the corresponding number of transactions is executed, and the production and consumption of all topics are summed up. After the consumption ends, the main thread ends. - Each consumer can have multiple subscriptions, but each subscription has only one consumer. In order to better compare the rate of production and consumption.

Master Issue: ##11765 ### Motivation - When opening a transaction, what is the delay and rate of pulsar sending and consuming messages? - How does the granularity of the transaction affect the rate at which pulsar produces or consumes messages - Is the rate of abort and commit transactions different - Try to keep the functions of ordinary produce perfand consume perf as much as possible ### Modifications Add PerformanceTransaction.Class - According to the number of topics set by the user, each topic starts a thread to execute a number of transactions asynchronously. - If there is a preset transaction value, the production or consumption of this topic is terminated after the corresponding number of transactions is executed, and the production and consumption of all topics are summed up. After the consumption ends, the main thread ends. - Each consumer can have multiple subscriptions, but each subscription has only one consumer. In order to better compare the rate of production and consumption. (cherry picked from commit 793a8b9)

lhotari · 2022-02-03T13:33:45Z

this PR introduced a flaky test, reported as #14109 . Please fix

gaoran10 reviewed Sep 6, 2021

View reviewed changes

gaoran10 assigned liangyepianzhou Sep 6, 2021

gaoran10 added the component/transactions label Sep 6, 2021

gaoran10 requested review from 315157973, codelipenghui, congbobo184, eolivelli, hangc0276 and zymap September 6, 2021 10:56

codelipenghui added this to the 2.9.0 milestone Sep 6, 2021

codelipenghui added release/2.8.2 area/transaction and removed component/transactions labels Sep 6, 2021

Anonymitaet added the doc-required Your PR changes impact docs and you will update later. label Sep 7, 2021

liangyepianzhou added 2 commits September 8, 2021 12:46

transaction-perf

1c4e7d5

transaction-perf

7472dca

liangyepianzhou marked this pull request as draft September 8, 2021 05:01

transaction-perf

026cb0f

eolivelli requested changes Sep 8, 2021

View reviewed changes

liangyepianzhou added 8 commits September 9, 2021 13:55

transaction-perf

34af7f3

transaction-perf

9b976bf

transaction-perf

fabe318

license header and checkstyle

edb09c7

license header and checkstyle

664013d

license header and checkstyle

b7307d9

Fixed some overlooked places

14c25f6

Fixed some overlooked places

57554ea

liangyepianzhou added 2 commits October 11, 2021 12:13

Optimize descriptions.

412ec79

Optimize argument default = false.

6dd9448

eolivelli requested changes Oct 12, 2021

View reviewed changes

Anonymitaet mentioned this pull request Oct 12, 2021

[Doc] Add pulsar-perf txn #12336

Merged

Resolve comments.

f91cbd6

eolivelli removed the release/2.8.2 label Oct 12, 2021

eolivelli modified the milestones: 2.9.0, 2.10.0 Oct 12, 2021

Optimize end transaction

b52cb95

Merge

0c2c32a

eolivelli requested changes Nov 17, 2021

View reviewed changes

pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java Outdated Show resolved Hide resolved

update

4ebce55

congbobo184 approved these changes Nov 19, 2021

View reviewed changes

liangyepianzhou requested a review from eolivelli November 19, 2021 09:27

eolivelli approved these changes Nov 22, 2021

View reviewed changes

congbobo184 merged commit 793a8b9 into apache:master Nov 22, 2021

congbobo184 added the release/2.9.2 label Dec 17, 2021

codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 21, 2021

Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Dec 31, 2021

lhotari mentioned this pull request Feb 3, 2022

Flaky-test: PerformanceTransactionTest.testConsumeTxnMessage #14109

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Transaction] Add transaction perf #11933

[Transaction] Add transaction perf #11933

liangyepianzhou commented Sep 6, 2021 •

edited

Loading

gaoran10 left a comment

liangyepianzhou commented Sep 6, 2021

Anonymitaet commented Sep 7, 2021

hangc0276 commented Sep 7, 2021

eolivelli left a comment

liangyepianzhou commented Oct 11, 2021

eolivelli Oct 12, 2021

eolivelli commented Oct 12, 2021

congbobo184 commented Nov 8, 2021

liangyepianzhou commented Nov 8, 2021

eolivelli left a comment

lhotari commented Feb 3, 2022

[Transaction] Add transaction perf #11933

[Transaction] Add transaction perf #11933

Conversation

liangyepianzhou commented Sep 6, 2021 • edited Loading

Motivation

Modifications

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

gaoran10 left a comment

Choose a reason for hiding this comment

liangyepianzhou commented Sep 6, 2021

Anonymitaet commented Sep 7, 2021

hangc0276 commented Sep 7, 2021

eolivelli left a comment

Choose a reason for hiding this comment

liangyepianzhou commented Oct 11, 2021

eolivelli Oct 12, 2021

Choose a reason for hiding this comment

eolivelli commented Oct 12, 2021

congbobo184 commented Nov 8, 2021

liangyepianzhou commented Nov 8, 2021

eolivelli left a comment

Choose a reason for hiding this comment

lhotari commented Feb 3, 2022

liangyepianzhou commented Sep 6, 2021 •

edited

Loading