[Issue 11936] forget to call SendCallback on producer close #11939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Sep 7, 2021
codelipenghui
requested review from
315157973,
eolivelli,
sijie,
zymap,
congbobo184,
gaoran10 and
hangc0276
codelipenghui
added
release/2.8.2
type/bug
315157973
approved these changes
Sep 7, 2021
hangc0276
approved these changes
Sep 7, 2021
|
@sijie @zymap @eolivelli @congbobo184 @gaoran10 PTAL thanks |
merlimat
approved these changes
Sep 7, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 9, 2021
* forget to call SendCallback on producer close * add unit tests * add unit tests (cherry picked from commit d494c43)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 27, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…1939) * forget to call SendCallback on producer close * add unit tests * add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11936
Motivation
Call SendCallback on the forgetten producer close branch.
Documentation
Need to update docs?
bug fix, no need doc