Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Expose Client.shutdown() method #11955

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Sep 7, 2021

Motivation

Similar to what we expose in Java and C++ client, we should expose the quick shutdown() method on the Python client.

@merlimat merlimat added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages release/2.8.2 labels Sep 7, 2021
@merlimat merlimat added this to the 2.9.0 milestone Sep 7, 2021
@merlimat merlimat self-assigned this Sep 7, 2021
@Anonymitaet
Copy link
Member

@merlimat do we need to update docs?

@BewareMyPower BewareMyPower added the doc-not-needed Your PR changes do not impact docs label Sep 8, 2021
@BewareMyPower
Copy link
Contributor

@Anonymitaet The docs have been added inside the code (shutdown), the associated docs will be generated like https://pulsar.apache.org/api/python/2.8.0-SNAPSHOT/#pulsar.Client.close

@BewareMyPower BewareMyPower merged commit c11ac89 into apache:master Sep 8, 2021
codelipenghui pushed a commit that referenced this pull request Sep 9, 2021
### Motivation

Similar to what we expose in Java and C++ client, we should expose the quick `shutdown()` method on the Python client.

(cherry picked from commit c11ac89)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 9, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
### Motivation

Similar to what we expose in Java and C++ client, we should expose the quick `shutdown()` method on the Python client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.0 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants