-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue-11966][pulsar-proxy] set default http proxy request timeout #11971
Conversation
@zzzming Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
@codelipenghui @rdhabalia @merlimat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@zzzming @lhotari @eolivelli this change does not take into consideration that upload and download of very large functions jars can easily take more than 30 sec. |
@merlimat ok, what would be a sufficient timeout value? |
Maybe we could try with something like 5min? |
…pache#11971) (cherry picked from commit 8b55636)
…pache#11971) (cherry picked from commit 8b55636)
Fixes #11966
Address missing http proxy request timeout in issue #11966
Motivation
Set http proxy request timeout in pulsar-proxy
Modifications
Set default http proxy request timeout in pulsar-proxy as 30 seconds
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changes