Remove python3 from vcpkg.json #12092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
type/bug
BewareMyPower
requested review from
aahmed-se,
codelipenghui,
jiazhai,
merlimat and
sijie
codelipenghui
approved these changes
Sep 18, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 19, 2021
### Motivation The master CI is broken by the Windows C++ build if the C++ related code was changed. See https://github.com/apache/pulsar/pull/12076/checks?check_run_id=3639836198 for example. It's because there's a bug in latest vcpkg for python3 build. See microsoft/vcpkg#20242. ### Modifications Remove the python3 dependency from vcpkg.json. Since the CI doesn't build Python wrapper, it won't affect the build. (cherry picked from commit fccc1cf)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation The master CI is broken by the Windows C++ build if the C++ related code was changed. See https://github.com/apache/pulsar/pull/12076/checks?check_run_id=3639836198 for example. It's because there's a bug in latest vcpkg for python3 build. See microsoft/vcpkg#20242. ### Modifications Remove the python3 dependency from vcpkg.json. Since the CI doesn't build Python wrapper, it won't affect the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The master CI is broken by the Windows C++ build if the C++ related code was changed. See https://github.com/apache/pulsar/pull/12076/checks?check_run_id=3639836198 for example.
It's because there's a bug in latest vcpkg for python3 build. See microsoft/vcpkg#20242.
Modifications
Remove the python3 dependency from vcpkg.json. Since the CI doesn't build Python wrapper, it won't affect the build.