[Cherry-pick] Pass client builder to debezium database history #12112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr is a little different with the original one. |
Technoboy-
changed the title
|
/pulsarbot run-failure-checks |
Technoboy-
force-pushed
the
cherry-pick-11293
branch
from
dd11428
to
7cf7315
Compare
Technoboy-
force-pushed
the
cherry-pick-11293
branch
from
7cf7315
to
d12444d
Compare
Technoboy-
changed the title
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jan 25, 2022
codelipenghui
added
cherry-picked/branch-2.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #11293
Motivation
The Debezium requires pulsar a service URL for history database usage.
In #11056 , the service.url field from PulsarKafkaWorkerConfig is no longer available. And the value is also deleted from multiple yaml config files in this commit. This causes the integration test for Debezium connector to fail.
Based on the Debezium paradigm, all configurations should be passed as strings. There's no easy way to inject a PulsarClient via configuration.
We need to ask user to provide the pulsar url explicitly and probably auth info also.
Modifications
Make the database.history.pulsar.service.url field required
Add the config value back to example yaml files
Update the integration test config