[Broker] Fix prefix setting in JWT authn and avoid multi calls for the getProperty #12132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anonymitaet
added
the
doc-required
|
@RobertIndie Thanks for your contribution. Please do not forget to add docs accordingly to allow users to know your great code changes. And you can ping me to review the docs, thanks. |
RobertIndie
force-pushed
the
fix-jwt-prefix
branch
from
4f1fbd4
to
e45b938
Compare
1 task
I have created a PR: #12152 for doc. PTAL |
|
/pulsarbot run-failure-checks |
codelipenghui
requested review from
sijie,
hangc0276,
cckellogg,
315157973 and
merlimat
...ommon/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java
Outdated
Show resolved
Hide resolved
Anonymitaet
removed
the
doc-required
Signed-off-by: Zike Yang <ar@armail.top>
|
/pulsarbot run-failure-checks |
315157973
reviewed
Oct 26, 2021
| @@ -54,7 +54,7 @@ | |||
| static final String HTTP_HEADER_VALUE_PREFIX = "Bearer "; | |||
|
|
|||
| // When symmetric key is configured | |||
| static final String CONF_TOKEN_SETTING_PREFIX = ""; | |||
| static final String CONF_TOKEN_SETTING_PREFIX = "tokenSettingPrefix"; | |||
There was a problem hiding this comment.
Will there be compatibility issues here? After the upgrade, the previous token cannot be used
There was a problem hiding this comment.
No compatibility issues will be introduced here. The tokenSettingPrefix is empty by default.
|
@RobertIndie PTAL |
codelipenghui
approved these changes
Nov 4, 2021
315157973
approved these changes
Nov 5, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Nov 5, 2021
…e getProperty (#12132) Motivation Currently, the setting prefix for JWT authentication does not work because the code does not specify the property name for the token setting prefix. Modifications Add token setting prefix property name: tokenSettingPrefix. Avoid multi calls for the getProperty in JWT auth. Verifying this change This change is already covered by the existing test, such as testTokenSettingPrefix. (cherry picked from commit b9a250d)
1 task
Anonymitaet
added
the
doc-complete
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…e getProperty (apache#12132) Motivation Currently, the setting prefix for JWT authentication does not work because the code does not specify the property name for the token setting prefix. Modifications Add token setting prefix property name: tokenSettingPrefix. Avoid multi calls for the getProperty in JWT auth. Verifying this change This change is already covered by the existing test, such as testTokenSettingPrefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the setting prefix for JWT authentication does not work because the code does not specify the property name for the token setting prefix.
Modifications
tokenSettingPrefix.Verifying this change
This change is already covered by the existing test, such as testTokenSettingPrefix.
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required