fix logger number not correct in tests #12168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Sep 24, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
eolivelli
approved these changes
Sep 24, 2021
codelipenghui
approved these changes
Sep 26, 2021
hangc0276
pushed a commit
that referenced
this pull request
Oct 17, 2021
Log placehodlers not correct. Cause some log info is missing or `{}` alone
Fix the placeholder, add `{}` or delete `{}`
(cherry picked from commit a69611c)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation
Log placehodlers not correct. Cause some log info is missing or `{}` alone
### Modifications
Fix the placeholder, add `{}` or delete `{}`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Log placehodlers not correct. Cause some log info is missing or
{}aloneModifications
Fix the placeholder, add
{}or delete{}Documentation
this is an internal optimize, don't need doc.