fix lost message issues 12221 #12223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
315157973
requested review from
codelipenghui,
hangc0276,
congbobo184 and
gaoran10
315157973
reviewed
Sep 29, 2021
| } | ||
| } | ||
|
|
||
| synchronized boolean isNeededCreateNewLedgerAfterCloseLedger() { |
There was a problem hiding this comment.
It seems that there is no need to add synchronized here
The following methods have synchronized, isNeededCreateNewLedgerAfterCloseLedger() is called inside them:
createLedgerAfterClosed()
ledgerClosed(final LedgerHandle lh)
internalAsyncAddEntry(OpAddEntry addOperation)
There was a problem hiding this comment.
yes, now it is not neccessary to add synchronized before isNeededCreateNewLedgerAfterCloseLedger method. and add synchronized now avoid it is used by others.
There was a problem hiding this comment.
We don't know the logic of subsequent calls to this method, whether the same lock (ML object) is used.
There was a problem hiding this comment.
ok, i change it later.
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Sep 30, 2021
codelipenghui
added
release/2.8.2
type/bug
jiazhai
approved these changes
Sep 30, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Oct 6, 2021
Fixes #12221 *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)* Master Issue: #12221 ### Motivation There are three way to create new ledger when one ledger is full. first: after add last entry for full ledger, it will handle create ledger processing. second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing. third: check ledger is or not full, when ledger is full, it will handle create ledger processing. So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one time. (cherry picked from commit eb9d9d4)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 27, 2021
Fixes apache#12221 *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)* Master Issue: apache#12221 ### Motivation There are three way to create new ledger when one ledger is full. first: after add last entry for full ledger, it will handle create ledger processing. second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing. third: check ledger is or not full, when ledger is full, it will handle create ledger processing. So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one time. (cherry picked from commit eb9d9d4) (cherry picked from commit e3c8386)
|
|
cc @baomingyu @315157973 PTAL |
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Mar 16, 2022
Fixes apache#12221 *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)* Master Issue: apache#12221 ### Motivation There are three way to create new ledger when one ledger is full. first: after add last entry for full ledger, it will handle create ledger processing. second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing. third: check ledger is or not full, when ledger is full, it will handle create ledger processing. So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one time.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Fixes apache#12221 *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)* Master Issue: apache#12221 ### Motivation There are three way to create new ledger when one ledger is full. first: after add last entry for full ledger, it will handle create ledger processing. second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing. third: check ledger is or not full, when ledger is full, it will handle create ledger processing. So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one time.
aloyszhang
pushed a commit
to aloyszhang/pulsar
that referenced
this pull request
Aug 5, 2022
Squash merge branch 'inlong-2.8.1.1-fix-lost-message' into 'inlong-2.8.1.1' cherry pick : Fix lost message issues 12221 (apache#12223)
Shawyeok
pushed a commit
to Shawyeok/pulsar
that referenced
this pull request
Sep 6, 2022
Fixes apache#12221 *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)* Master Issue: apache#12221 ### Motivation There are three way to create new ledger when one ledger is full. first: after add last entry for full ledger, it will handle create ledger processing. second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing. third: check ledger is or not full, when ledger is full, it will handle create ledger processing. So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12221
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #12221
Motivation
There are three way to create new ledger when one ledger is full.
first: after add last entry for full ledger, it will handle create ledger processing.
second: check ledger is or not full, when ledger is full and appendingAddEntries is not empty, it will handle create ledger processing.
third: check ledger is or not full, when ledger is full, it will handle create ledger processing.
So we need check it is or not creating or has created when concurrent create new ledger. avoid to create three new ledgers one time.