[Metrics] Add support for splitting topic and partition label in Prometheus #12225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etheus Fix: apache#11432 Currently, we are only expose the partition name for the topic label in Prometheus metrics, which is difficult to have an aggregated metrics for a partitioned topic. Before this change, we can only get (topic=xxx-partition-0) in the metrics. After this change, we can get 2 labels (topic=xxx, partition=0). By default, the broker expose the single tag for topic. It need to change `splitTopicAndPartitionLabelInPrometheus=true` in the broker.conf New tests added.
codelipenghui
added
type/enhancement
codelipenghui
requested review from
hangc0276,
sijie,
315157973,
merlimat and
eolivelli
hangc0276
approved these changes
Sep 29, 2021
merlimat
approved these changes
Sep 30, 2021
codelipenghui
added a commit
that referenced
this pull request
Oct 6, 2021
…etheus (#12225) * [Metrics] Add support for splitting topic and partition label in Prometheus Fix: #11432 Currently, we are only expose the partition name for the topic label in Prometheus metrics, which is difficult to have an aggregated metrics for a partitioned topic. Before this change, we can only get (topic=xxx-partition-0) in the metrics. After this change, we can get 2 labels (topic=xxx, partition=0). By default, the broker expose the single tag for topic. It need to change `splitTopicAndPartitionLabelInPrometheus=true` in the broker.conf New tests added. * Fix checkstyle. (cherry picked from commit 039079e)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 25, 2022
…etheus (apache#12225) * [Metrics] Add support for splitting topic and partition label in Prometheus Fix: apache#11432 Currently, we are only expose the partition name for the topic label in Prometheus metrics, which is difficult to have an aggregated metrics for a partitioned topic. Before this change, we can only get (topic=xxx-partition-0) in the metrics. After this change, we can get 2 labels (topic=xxx, partition=0). By default, the broker expose the single tag for topic. It need to change `splitTopicAndPartitionLabelInPrometheus=true` in the broker.conf New tests added. * Fix checkstyle. (cherry picked from commit 039079e) (cherry picked from commit 5fad80c)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…etheus (apache#12225) * [Metrics] Add support for splitting topic and partition label in Prometheus Fix: apache#11432 Currently, we are only expose the partition name for the topic label in Prometheus metrics, which is difficult to have an aggregated metrics for a partitioned topic. Before this change, we can only get (topic=xxx-partition-0) in the metrics. After this change, we can get 2 labels (topic=xxx, partition=0). By default, the broker expose the single tag for topic. It need to change `splitTopicAndPartitionLabelInPrometheus=true` in the broker.conf New tests added. * Fix checkstyle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #11432
Currently, we are only exposing the partition name for the topic label in Prometheus metrics, which is difficult to
have an aggregated metrics for a partitioned topic.
Before this change, we can only get (topic=xxx-partition-0) in the metrics. After this change, we can get 2 labels (topic=xxx, partition=0).
By default, the broker exposes the single tag for the topic. It need to change
splitTopicAndPartitionLabelInPrometheus=truein the broker.confNew tests added.