Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-io-kinesis] add missing dependency #12246

Merged

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Sep 30, 2021

Motivation

Kinesis connector throws java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter exception while init.

According to awslabs/amazon-kinesis-producer#242, added the missing dependency to pom.xml

Modifications

  • add javax.xml.bind jaxb-api to pom.xml

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet added this to the 2.9.0 milestone Sep 30, 2021
@freeznet freeznet self-assigned this Sep 30, 2021
@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Sep 30, 2021
@freeznet freeznet merged commit c823c08 into apache:master Sep 30, 2021
@david-streamlio
Copy link
Contributor

LGTM +1

codelipenghui pushed a commit that referenced this pull request Oct 6, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Oct 6, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
dlg99 pushed a commit to dlg99/pulsar that referenced this pull request Mar 20, 2022
(cherry picked from commit c823c08)
(cherry picked from commit c17cd00)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Mar 21, 2022
(cherry picked from commit c823c08)
(cherry picked from commit c17cd00)

Co-authored-by: Rui Fu <freeznet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants