fix ttl expiry does not take effect #12266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codelipenghui @315157973 PTAL |
codelipenghui
approved these changes
Oct 9, 2021
codelipenghui
added
type/bug
codelipenghui
requested review from
eolivelli,
hangc0276,
315157973 and
merlimat
codelipenghui
pushed a commit
that referenced
this pull request
Oct 11, 2021
Fixes #12265 ### Motivation fix ttl expiry does not take effect ### Modifications When `ManagedLedgerImpl.getPositionAfterN` 1. check whether the `currentLeder` contains entry when count the entries of `currentLeder` 2. check the result and `LAC` first before return ### Verifying this change add test in `ManagedLedgerTest.testGetPositionAfterN` (cherry picked from commit aa408ff)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Fixes apache#12265 ### Motivation fix ttl expiry does not take effect ### Modifications When `ManagedLedgerImpl.getPositionAfterN` 1. check whether the `currentLeder` contains entry when count the entries of `currentLeder` 2. check the result and `LAC` first before return ### Verifying this change add test in `ManagedLedgerTest.testGetPositionAfterN`
aloyszhang
pushed a commit
to aloyszhang/pulsar
that referenced
this pull request
Aug 5, 2022
…master branch (merge request !25) Squash merge branch 'merge-2.8.1.1' into 'inlong-2.8.1.1' This merge request including two genaral parts. 1. Internal modifies a) introduce TAuth authentaciation and Apache Ranger authenrization b) introduce produce&consume metrics at minute level and support reporter for both local file and ngcp c) add log configurations for local file metric reporter d) add INLONG-RELEASE log which record all internal changes and cherry-picks 2. Cherry-picks fix ttl expiry does not take effect (apache#12266) Fix seek at batchIndex level receive duplicated messages (apache#11826)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12265
Motivation
fix ttl expiry does not take effect
Modifications
When
ManagedLedgerImpl.getPositionAfterNcurrentLedercontains entry when count the entries ofcurrentLederLACfirst before returnVerifying this change
add test in
ManagedLedgerTest.testGetPositionAfterNIf
yeswas chosen, please highlight the changesDocumentation
No-doc-need since this pull request is a inner bug fix.