[pulsar-admin] Modify exception of set-properties for namespace #12436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Oct 24, 2021
codelipenghui
added
the
type/enhancement
codelipenghui
requested review from
hangc0276,
315157973,
eolivelli,
gaoran10,
merlimat and
congbobo184
k2la
approved these changes
Oct 26, 2021
315157973
approved these changes
Nov 1, 2021
hangc0276
pushed a commit
that referenced
this pull request
Nov 4, 2021
when I execute ./pulsar-admin namespaces set-properties --properties a=a=b test/app1 we hope to display a readable prompt of set-properties for namespace when exception occurs. Modifications Change IllegalArgumentException to ParameterException (cherry picked from commit cd9a65e)
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…he#12436) when I execute ./pulsar-admin namespaces set-properties --properties a=a=b test/app1 we hope to display a readable prompt of set-properties for namespace when exception occurs. Modifications Change IllegalArgumentException to ParameterException
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
when I execute ./pulsar-admin namespaces set-properties --properties a=a=b test/app1 we hope to display a readable prompt of set-properties for namespace when exception occurs. Modifications Change IllegalArgumentException to ParameterException (cherry picked from commit cd9a65e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
when I execute
./pulsar-admin namespaces set-properties --properties a=a=b test/app1, a prompt as below:we hope to display a readable prompt of
set-propertiesfor namespace when exception occurs.Modifications
IllegalArgumentExceptiontoParameterExceptionDocumentation
no-need-doc