Reduce the readFailureBackoff time #12444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- *Motivation* When reading entries met exception, teh dispatcher will backoff 15s to start next read. The 15s is unacceptable at most of case for the consumer. So it's better to reduce the interval. *Modifications* Make the read failure backoff start from 1s.
zymap
added
doc-not-needed
|
@merlimat Please help review this PR, it decrease the backoff interval, and will increate the retry interval. I'm not sure whether it will introduce other performance impact. |
| @@ -65,7 +65,7 @@ | |||
| protected volatile boolean havePendingRead = false; | |||
|
|
|||
| protected volatile int readBatchSize; | |||
| protected final Backoff readFailureBackoff = new Backoff(15, TimeUnit.SECONDS, | |||
| protected final Backoff readFailureBackoff = new Backoff(1, TimeUnit.SECONDS, | |||
There was a problem hiding this comment.
Can we make it configurable at the broker.conf? In some cases, May 1 sec is still too long.
codelipenghui
approved these changes
Oct 22, 2021
hangc0276
approved these changes
Oct 22, 2021
zymap
added a commit
that referenced
this pull request
Oct 22, 2021
### Motivation When reading entries met exception, the dispatcher will backoff 15s to start next read. The 15s is unacceptable at most of case for the consumer. So it's better to reduce the interval. ### Modifications Make the read failure backoff start from 1s. (cherry picked from commit 99c90a5)
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
### Motivation When reading entries met exception, the dispatcher will backoff 15s to start next read. The 15s is unacceptable at most of case for the consumer. So it's better to reduce the interval. ### Modifications Make the read failure backoff start from 1s.
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
### Motivation When reading entries met exception, the dispatcher will backoff 15s to start next read. The 15s is unacceptable at most of case for the consumer. So it's better to reduce the interval. ### Modifications Make the read failure backoff start from 1s. (cherry picked from commit 99c90a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When reading entries met exception, teh dispatcher will backoff 15s
to start next read. The 15s is unacceptable at most of case for the
consumer. So it's better to reduce the interval.
Modifications
Make the read failure backoff start from 1s.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)