Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topicName need trim #12453

Merged
merged 1 commit into from
Oct 21, 2021
Merged

topicName need trim #12453

merged 1 commit into from
Oct 21, 2021

Conversation

lordcheng10
Copy link
Contributor

@lordcheng10 lordcheng10 commented Oct 21, 2021 •
edited
Loading

When using the perf command, the incoming topic name does not have trim, which may cause the parsed topic name to contain spaces. When automatic topic creation is enabled, topics with spaces will also be automatically created:
image

Perf command used：nohup sh pulsar-perf consume -st Exclusive -ss chenlin_t1 test1 > log1 &
Note that there is a space after test1.

@lordcheng10
When using the perf command, the incoming topic name does not have tr…
481a0a1 
…im, which may cause the parsed topic name to contain spaces. When automatic topic creation is enabled, topics with spaces will also be automatically created
@eolivelli
Copy link
Contributor

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli
Copy link
Contributor

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@lordcheng10
Copy link
Contributor Author

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

No documentation required here

@merlimat merlimat added this to the 2.10.0 milestone Oct 21, 2021
@merlimat merlimat merged commit 557dfd2 into apache:master Oct 21, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@lordcheng10 @eolivelli
When using the perf command, the incoming topic name does not have tr…
7a6d595 
…im, which may cause the parsed topic name to contain spaces. When automatic topic creation is enabled, topics with spaces will also be automatically created (apache#12453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@lordcheng10 lordcheng10

Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lordcheng10 @eolivelli @merlimat