-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add OpAddEntry to pendingAddEntries after the state check #12570
[ML] Add OpAddEntry to pendingAddEntries after the state check #12570
Conversation
- when the state was Fenced, Terminated or Closed, the OpAddEntry instance would remain in pendingAddEntries although the operation is failed immediately.
@lhotari:Thanks for your contribution. For this PR, do we need to update docs? |
@lhotari:Thanks for your contribution. For this PR, do we need to update docs? |
1 similar comment
@lhotari:Thanks for your contribution. For this PR, do we need to update docs? |
@lhotari:Thanks for providing doc info! |
@lhotari One consequence of this issue is that messages can be delivered out-of-order in some scenarios. Is that correct? |
- when the state was Fenced, Terminated or Closed, the OpAddEntry instance would remain in pendingAddEntries although the operation is failed immediately. (cherry picked from commit 409239c)
…e#12570) - when the state was Fenced, Terminated or Closed, the OpAddEntry instance would remain in pendingAddEntries although the operation is failed immediately.
- when the state was Fenced, Terminated or Closed, the OpAddEntry instance would remain in pendingAddEntries although the operation is failed immediately. (cherry picked from commit 409239c)
- when the state was Fenced, Terminated or Closed, the OpAddEntry instance would remain in pendingAddEntries although the operation is failed immediately. (cherry picked from commit 409239c)
- when the state was Fenced, Terminated or Closed, the OpAddEntry instance would remain in pendingAddEntries although the operation is failed immediately. (cherry picked from commit 409239c)
Motivation
instance would remain in pendingAddEntries although the operation is failed
immediately.
Modifications