Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add OpAddEntry to pendingAddEntries after the state check #12570

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Nov 1, 2021

Motivation

  • when the state was Fenced, Terminated or Closed, the OpAddEntry
    instance would remain in pendingAddEntries although the operation is failed
    immediately.

Modifications

  • add OpAddEntry to pendingAddEntries after the state check

- when the state was Fenced, Terminated or Closed, the OpAddEntry
  instance would remain in pendingAddEntries although the operation is failed
  immediately.
@lhotari lhotari added type/bug The PR fixed a bug or issue reported a bug area/broker labels Nov 1, 2021
@lhotari lhotari added this to the 2.10.0 milestone Nov 1, 2021
@lhotari lhotari self-assigned this Nov 1, 2021
@github-actions
Copy link

github-actions bot commented Nov 1, 2021

@lhotari:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

@lhotari:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 1, 2021

@lhotari:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@lhotari lhotari added the doc-not-needed Your PR changes do not impact docs label Nov 1, 2021
@github-actions
Copy link

github-actions bot commented Nov 1, 2021

@lhotari:Thanks for providing doc info!

@merlimat merlimat merged commit 409239c into apache:master Nov 2, 2021
lhotari added a commit to lhotari/pulsar that referenced this pull request Nov 2, 2021
…e#12570)

- when the state was Fenced, Terminated or Closed, the OpAddEntry
  instance would remain in pendingAddEntries although the operation is failed
  immediately.

(cherry picked from commit 409239c)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Nov 2, 2021
…e#12570)

- when the state was Fenced, Terminated or Closed, the OpAddEntry
  instance would remain in pendingAddEntries although the operation is failed
  immediately.

(cherry picked from commit 409239c)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Nov 2, 2021
…e#12570)

- when the state was Fenced, Terminated or Closed, the OpAddEntry
  instance would remain in pendingAddEntries although the operation is failed
  immediately.

(cherry picked from commit 409239c)
@cdbartholomew
Copy link
Contributor

@lhotari One consequence of this issue is that messages can be delivered out-of-order in some scenarios. Is that correct?

hangc0276 pushed a commit that referenced this pull request Nov 4, 2021
- when the state was Fenced, Terminated or Closed, the OpAddEntry
  instance would remain in pendingAddEntries although the operation is failed
  immediately.

(cherry picked from commit 409239c)
@hangc0276 hangc0276 added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Nov 4, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
…e#12570)

- when the state was Fenced, Terminated or Closed, the OpAddEntry
  instance would remain in pendingAddEntries although the operation is failed
  immediately.
codelipenghui pushed a commit that referenced this pull request Dec 11, 2021
- when the state was Fenced, Terminated or Closed, the OpAddEntry
  instance would remain in pendingAddEntries although the operation is failed
  immediately.

(cherry picked from commit 409239c)
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Dec 11, 2021
eolivelli pushed a commit that referenced this pull request Dec 15, 2021
- when the state was Fenced, Terminated or Closed, the OpAddEntry
  instance would remain in pendingAddEntries although the operation is failed
  immediately.

(cherry picked from commit 409239c)
@eolivelli eolivelli added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 15, 2021
eolivelli pushed a commit that referenced this pull request Dec 15, 2021
- when the state was Fenced, Terminated or Closed, the OpAddEntry
  instance would remain in pendingAddEntries although the operation is failed
  immediately.

(cherry picked from commit 409239c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-2.7 Archived: 2.7 is end of life cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.7.4 release/2.8.2 release/2.9.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants