Fix additional servlets nar might extract to null directory #12585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Demogorgon314:Thanks for providing doc info! |
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 3, 2021
Demogorgon314
deleted the
Fix_additional_servlets_nar_might_extract_to_null_directory
branch
codelipenghui
pushed a commit
that referenced
this pull request
Nov 5, 2021
### Motivation The additional servlets use NAR package to implantation plugin mechanism, it need extract to specific directory. However, the `narExtractionDirectory` is from `Properties`, but the properties has only the configuration in the configuration file. The default value of `narExtractionDirectory ` in `ServiceConfiguration` can't be use. ### Modifications When `narExtractionDirectory ` configuration is not set, use `NarClassLoader.DEFAULT_NAR_EXTRACTION_DIR` as default directory. (cherry picked from commit 9ecd613)
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…2585) ### Motivation The additional servlets use NAR package to implantation plugin mechanism, it need extract to specific directory. However, the `narExtractionDirectory` is from `Properties`, but the properties has only the configuration in the configuration file. The default value of `narExtractionDirectory ` in `ServiceConfiguration` can't be use. ### Modifications When `narExtractionDirectory ` configuration is not set, use `NarClassLoader.DEFAULT_NAR_EXTRACTION_DIR` as default directory.
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
### Motivation The additional servlets use NAR package to implantation plugin mechanism, it need extract to specific directory. However, the `narExtractionDirectory` is from `Properties`, but the properties has only the configuration in the configuration file. The default value of `narExtractionDirectory ` in `ServiceConfiguration` can't be use. ### Modifications When `narExtractionDirectory ` configuration is not set, use `NarClassLoader.DEFAULT_NAR_EXTRACTION_DIR` as default directory. (cherry picked from commit 9ecd613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The additional servlets use NAR package to implantation plugin mechanism, it need extract to specific directory.
However, the
narExtractionDirectoryis fromProperties, but the properties has only the configuration in theconfiguration file. The default value of
narExtractionDirectoryinServiceConfigurationcan't be use.Modifications
When
narExtractionDirectoryconfiguration is not set, useNarClassLoader.DEFAULT_NAR_EXTRACTION_DIRas default directory.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
no-need-docThis a bug fix, no need docs.