Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix String should use equals but not ==. #12619

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Fix String should use equals but not ==. #12619

merged 1 commit into from
Nov 5, 2021

Conversation

casuallc
Copy link
Contributor

@casuallc casuallc commented Nov 4, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

@casuallc:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@codelipenghui codelipenghui added this to the 2.10.0 milestone Nov 4, 2021
eolivelli
eolivelli approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Thanks

@315157973 315157973 merged commit c2165e8 into apache:master Nov 5, 2021
codelipenghui pushed a commit that referenced this pull request Nov 18, 2021
@casuallc @codelipenghui
Fix String should use equals but not ==. (#12619)
5c51475 
Fix String should use equals but not ==

(cherry picked from commit c2165e8)
@codelipenghui codelipenghui added release/2.8.2 cherry-picked/branch-2.8 Archived: 2.8 is end of life and removed release/2.8.3 labels Nov 18, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@casuallc @eolivelli
Fix String should use equals but not ==. (apache#12619)
38a629f 
Fix String should use equals but not ==
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@casuallc @codelipenghui
Fix String should use equals but not ==. (#12619)
4421d17 
Fix String should use equals but not ==

(cherry picked from commit c2165e8)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
@casuallc casuallc deleted the fix_1104 branch March 4, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@315157973 315157973 315157973 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@shoothzj shoothzj shoothzj approved these changes

@yuruguo yuruguo yuruguo approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

Assignees

@casuallc casuallc

Labels
area/broker cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.2
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
7 participants
@casuallc @eolivelli @315157973 @codelipenghui @shoothzj @yuruguo @RobertIndie