-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove corrupt visible testing annotation in function workers #12621
Remove corrupt visible testing annotation in function workers #12621
Conversation
@shoothzj:Thanks for providing doc info! |
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
What do you mean with 'corrupt'? Do you mean 'wrong ' ?
I mean, After a long time, the method annotated |
1 similar comment
I mean, After a long time, the method annotated |
…2621) * Remove wrong visible testing annotation * Remove unused method since 2017
* Remove wrong visible testing annotation * Remove unused method since 2017 (cherry picked from commit 8496afc)
Motivation
Remove corrupt visible testing annotation in function workers, make code reader confusing
Modifications
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc
simple internal changes