Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove corrupt visible testing annotation in function workers #12621

Merged

Conversation

shoothzj
Copy link
Member

@shoothzj shoothzj commented Nov 4, 2021

Motivation

Remove corrupt visible testing annotation in function workers, make code reader confusing

Modifications

  • Remove corrupt visible testing annotation
  • fix a typo
  • rename a unused method since 2017

Documentation

Check the box below and label this PR (if you have committer privilege).
Need to update docs?

  • no-need-doc
    simple internal changes

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

@shoothzj:Thanks for providing doc info!

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 4, 2021
@shoothzj
Copy link
Member Author

shoothzj commented Nov 4, 2021

/pulsarbot run-failure-checks

1 similar comment
@shoothzj
Copy link
Member Author

shoothzj commented Nov 4, 2021

/pulsarbot run-failure-checks

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

What do you mean with 'corrupt'? Do you mean 'wrong ' ?

@shoothzj
Copy link
Member Author

shoothzj commented Nov 4, 2021

Lgtm

What do you mean with 'corrupt'? Do you mean 'wrong ' ?

I mean, After a long time, the method annotated VisibleTesting has already been used by src code

1 similar comment
@shoothzj
Copy link
Member Author

shoothzj commented Nov 4, 2021

Lgtm

What do you mean with 'corrupt'? Do you mean 'wrong ' ?

I mean, After a long time, the method annotated VisibleTesting has already been used by src code

@eolivelli eolivelli merged commit 8496afc into apache:master Nov 5, 2021
@shoothzj shoothzj deleted the remove-corrupt-visible-testing-annotation branch November 5, 2021 07:49
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
…2621)

* Remove wrong visible testing annotation

* Remove unused method since 2017
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
* Remove wrong visible testing annotation

* Remove unused method since 2017

(cherry picked from commit 8496afc)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants