Fix false positive ownership check in OwnershipCache#checkOwnership #12650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wnershipCache#checkOwnership
Jason918
changed the title
codelipenghui
approved these changes
Nov 6, 2021
merlimat
approved these changes
Nov 6, 2021
codelipenghui
added
cherry-picked/branch-2.8
lhotari
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 3, 2021
…wnershipCache#checkOwnership (apache#12650) Co-authored-by: Jiang Haiting <jianghaiting@didichuxing.com> (cherry picked from commit 52764ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Motivation
In OwnershipCache#checkOwnership, it will lookup in zk (
resolveOwnership) if we can not find owner info in local cache.It is possible that the bundle owner could be other brokers when resolveOwnership returning non-empty result.
PS. It's just on branch 2.8
In 2.9, the resolveOwnership method is removed.
Modifications
Just revert this code line to previous version, which should be correct.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docBug fix, no user behavior changed.