Remove unnecessary powermock annotation #12713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Nov 10, 2021
|
I am +1 as long as the tests that we modified pass both on JDK11 and on JDK8 those annotations where there because of some weird behaviour on some JDK @shoothzj can you please verify ? |
I have runned use jdk11, you mean run again use jdk8 ? |
|
yes |
shoothzj
force-pushed
the
remove-unnecessary-powermock
branch
from
52f6807
to
d06fa2c
Compare
|
|
/pulsarbot run-failure-checks |
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Dec 20, 2021
(cherry picked from commit 8cae635)
gaoran10
added
the
type/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove unnecessary powermock annotation. I think that can make tests run faster.
Verifying this change
run test local ok.
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doclittle modification for test code.