[Issue 12723] Fix race condition in PersistentTopic#addReplicationCluster #12729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
codelipenghui
approved these changes
Nov 11, 2021
codelipenghui
added
cherry-picked/branch-2.8
lhotari
reviewed
Nov 23, 2021
| @SuppressFBWarnings | ||
| @Override | ||
| public boolean equals(Object obj) { | ||
| return obj == null; |
There was a problem hiding this comment.
this looks like a solution that violates the contract of Object.equals. Isn't there an alternative way to achieve the desired outcome?
There was a problem hiding this comment.
found this comment as context: #12723 (comment) .
@merlimat would you be able to take a look at the problem and this solution?
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…ster (apache#12729) ### Motivation See apache#12723 ### Modifications Add a method org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap#removeNullValue to remove null value in a thread safe way.
lhotari
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 3, 2021
…ster (apache#12729) See apache#12723 Add a method org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap#removeNullValue to remove null value in a thread safe way. (cherry picked from commit a3fe00e) (cherry picked from commit 230e1ac)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…ster (apache#12729) ### Motivation See apache#12723 ### Modifications Add a method org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap#removeNullValue to remove null value in a thread safe way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12723
Motivation
See #12723
Modifications
Add a method org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap#removeNullValue to remove null value in a thread safe way.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docBug fix.